Plugins/Flow.Launcher.Plugin.Shell/Converters/LeaveShellOpenOrCloseShellAfterPressEnabledConverter.cs (1)

9-19: Converter logic matches requirements

Enables only when the other option is false and shell != RunCommand. Meets “disable when RunCommand” objective.

For safer defaults during binding initialization, consider returning false instead of Binding.DoNothing so controls start disabled until values are ready.

Plugins/Flow.Launcher.Plugin.Shell/Main.cs (2)

132-136: Guard against zero/invalid history limit

If ShowOnlyMostUsedCMDsNumber is 0, users get no history. Clamp to a minimum of 1 when limiting is enabled.

Apply this diff in both places:

-            if (_settings.ShowOnlyMostUsedCMDs)
-                return [.. history.Take(_settings.ShowOnlyMostUsedCMDsNumber)];
+            if (_settings.ShowOnlyMostUsedCMDs)
+            {
+                var n = Math.Max(1, _settings.ShowOnlyMostUsedCMDsNumber);
+                return [.. history.Take(n)];
+            }

Also applies to: 185-189

---

66-68: Duplicate predicate in autocomplete filter

The results.Any(p => o.Equals(p.Title, ...)) check is repeated twice. Drop one for clarity.

-                                .Where(o => o.StartsWith(cmd, StringComparison.OrdinalIgnoreCase) &&
-                                            !results.Any(p => o.Equals(p.Title, StringComparison.OrdinalIgnoreCase)) &&
-                                            !results.Any(p => o.Equals(p.Title, StringComparison.OrdinalIgnoreCase))).ToList();
+                                .Where(o => o.StartsWith(cmd, StringComparison.OrdinalIgnoreCase) &&
+                                            !results.Any(p => o.Equals(p.Title, StringComparison.OrdinalIgnoreCase))).ToList();

Plugins/Flow.Launcher.Plugin.Shell/Views/ShellSetting.xaml.cs (1)

10-14: Remove redundant DataContext assignment

DataContext = viewModel; is set twice. Keep one (before InitializeComponent is fine if XAML bindings depend on it).

-            DataContext = viewModel;
-            InitializeComponent();
-            DataContext = viewModel;
+            DataContext = viewModel;
+            InitializeComponent();

Plugins/Flow.Launcher.Plugin.Shell/ViewModels/ShellSettingViewModel.cs (1)

74-77: Fail fast on null settings
Please guard the constructor argument so we fail fast with a descriptive ArgumentNullException instead of running into harder-to-debug null dereferences later.

-    public ShellSettingViewModel(Settings settings)
-    {
-        Settings = settings;
-    }
+    public ShellSettingViewModel(Settings settings)
+    {
+        Settings = settings ?? throw new ArgumentNullException(nameof(settings));
+    }

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro